feat(ctest): add compact output filter#2250
Open
jsiu93 wants to merge 2 commits into
Open
Conversation
599e93d to
e8493eb
Compare
# Conflicts: # src/cmds/system/pipe_cmd.rs
3d3e3d5 to
3964bea
Compare
Contributor
Author
|
@KuSh @aeppling That benchmark calls Here is a local example showing two different response shapes: ❯ rtk curl -s https://mockhttp.org/json
{"message":"Hello from MockHTTP","timestamp":"2026-07-03T02:05:44.002Z","status":"success","code":200}
❯ curl -s https://mockhttp.org/json
{"metrics":{"cpu":45.2,"memory":78.5,"disk":62.3,"network":{"inbound":"1.2MB/s","outbound":"0.8MB/s"},"uptime":"15 days","services":[{"name":"api","status":"healthy"},{"name":"database","status":"healthy"},{"name":"cache","status":"warning"}]}}
A deterministic local HTTP fixture, or capturing one response and feeding the same body to both commands, should make this benchmark stable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk ctestwith compact CTest output for green runs and preserved failing-test details.ctestin hook rewrite/discover, pipe filtering, tracking, and TOML shadow warnings.Closes #2237
Test plan
cargo fmt -- --checkcargo test ctestcargo testcargo clippy -- -D warningscargo run --quiet -- rewrite "ctest -R smoke --output-on-failure"cargo run --quiet -- pipe --filter ctestwith sample CTest output