Conversation
hibtypes.el
Outdated
| ;; suffixes, so use it only when the file | ||
| ;; either doesn't have a suffix or has a | ||
| ;; library suffix. | ||
| (let ((ext (file-name-extension file))) |
There was a problem hiding this comment.
Uses a let for the free var ext to bind it.
Plus uses when instead of an and to make the intent clearer. IMHO. WDYT?
Also fixes the indentation that was a bit off.
Note
The comment does not align properly too so looks odd here in the web interface. I think it is due to a mix of space and tabs in the file. I was thinking of fixing the whitespace in the file but decided to postpone this as a separate step since it would make reviewing these small changes much harder. Let me know if I can fix the whitespace in hibtypes.el as a separate commit to this PR or if we wait with that.
There was a problem hiding this comment.
Take the hibtypes change out entirely, as I have merged this change already, and then I will approve.
There was a problem hiding this comment.
OK. I'll rebase and fix it.
I see now that you did not merge your change to master so I just reverted the commit with the hibtypes change as you suggested. Should be fine to review now.
matsl
force-pushed
the
pr_remove_warnings
branch
from
8d1a023 to
8f27538
Compare
* hibtypes.el (hib-link-to-file-line): Use let for undefined free var
ext. Fix indentation.
* hywiki.el (consult-grep-args, consult-ripgrep-args): Defvar consult
variables.
(hywiki-org-to-heading-instance): Use with-suppressed-warnings for
obsolete org-show-entry.
* hui-mouse.el (profiler-report-find-entry)
(profiler-report-toggle-entry): Declare functions. Sort the functions.
(smart-profiler-report): Shorten docstring line below 80
chars. Do explicit initialization of curr-buffer since
byte-compiler does not see it will be set.
This reverts commit 6f73d0b.
matsl
force-pushed
the
pr_remove_warnings
branch
from
a7f67e1 to
3967abd
Compare
2 participants
What
Silence byte compilation warnings.
Why
Warnings can indicate issues so we keep them low so that they are easy
to spot and act on.
Note
I missed to cook up a ChangeLog update for this. But it made rebase a breeze. I'll add that later today.The ChangeLog is added.Maybe I should always just add the ChangeLog item as a comment to be inserted when the PR is merged? It is 99% of the time a conflict in the ChangeLog that cause conflicts and requires rebasing. 😄