Merged
Conversation
jacquelinekay
added
in review
Member
|
+1 |
Member
There was a problem hiding this comment.
This looks weird to me. The template accepts multiple arguments now (e.g. Foo, Bar) which then ends up as const Foo, Bar &?
Contributor
Author
There was a problem hiding this comment.
yes. I wasn't sure how else to allow passing a class with multiple template arguments to these macros.
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
…ondition_tests reenable tests for rcl_node_get_graph_guard_condition for all rmw impl
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Oct 3, 2023
…iron Do not crash Executor when send_response fails due to client failure.…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While exposing the allocator template in rclcpp, I noticed our macro definitions have trouble when there are commas in a type (i.e. when there are multiple template arguments). I decided to change all the macro definitions to variadic macros, which will allow commas in the type names.