ref(typescript): remove resolve package#1742
Closed
AbhiPrasad wants to merge 1 commit intorollup:masterfrom
Closed
ref(typescript): remove resolve package#1742AbhiPrasad wants to merge 1 commit intorollup:masterfrom
AbhiPrasad wants to merge 1 commit intorollup:masterfrom
Conversation
@rollup/plugin-typescript requires Node 14 or higher, so we can switch from using the resolve package to built-in `require.resolve`.
AbhiPrasad
changed the title
benmccann
reviewed
Jul 1, 2024
| @@ -1,4 +1,4 @@ | |||
| lockfileVersion: '6.0' | |||
| lockfileVersion: '9.0' | |||
Contributor
There was a problem hiding this comment.
just noting that this is upgrading pnpm. i'm also on the new version of pnpm. I sent a PR for that here: #1740. If that PR gets merged, you might be able to rebase this to have a smaller diff of the lockfile
Author
There was a problem hiding this comment.
thanks for the highlight - was wondering why there was a bigger diff there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
No relevant issue numbers, but this may solve #1700 and #1703 because we are using the native node resolver.
Description
@rollup/plugin-typescriptrequires Node 14 or higher, so we can switch from using the resolve package to built-inrequire.resolve.https://npmgraph.js.org/?q=%40rollup%2Fplugin-typescript#select=exact%3Aresolve%401.22.8