Fix viewer nav overlap and mobile shell layout#369
Conversation
|
@nightskat is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe viewer's single HTML file undergoes a comprehensive layout reorganization: new CSS container classes ( ChangesViewer Layout Restructuring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/viewer/index.html`:
- Around line 202-210: The active view currently fills the entire .app-main
(overflow: hidden on .app-main + .view {height: 100%}) which pushes the footer
off-screen; change the sizing model so the view participates in flex layout
instead of forcing full height: remove or replace .view { height: 100% } with a
flex rule (e.g., .view { flex: 1 1 auto; height: auto; overflow-y: auto; })
and/or remove overflow: hidden from .app-main so the footer can be reached;
update .view.active to keep display:block and scrolling via overflow-y instead
of full-height takeover.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Summary
Why
On the viewer, tabs from roughly Sessions onward could render over the navigation area: the nav became invisible while still remaining clickable underneath. The shell also behaved poorly on narrower widths because the header/tab row had no real responsive fallback.
Notes
Summary by CodeRabbit
Style
Refactor