ROCK_BUNDLE_PATH should only define super folder of bundles

[maltewi]

ROCK_BUNDLE_PATH should only contain higher-level folder where bundles can be found as subfolders. It should not contain the bundle folders themselves.

[doudou]

Actually, it could by design. The idea was that not all bundles might end up in a "bundle" folder.

I am open for discussion there, though. What was your problem ?

[maltewi]

I had two problems (possibly related):

1. Errors from another bundle leak into the current one.
   E.g. put some random text into models/actions/main.rb of bundle 'B'. It
   will break a syskit instanciate command in another bundle ('A') which
   has no dependency on bundle 'B'.

2. Searching for files behaves not as expected.
   I would expect that Roby.app.find_files_in_dirs is limited to the
   loaded bundles, but is searches within all folders defined in
   ROCK_BUNDLE_PATH.

[doudou]

Should definitely not happen. My guess is that modifying the ROCK_BUNDLE_PATH the way you want actually simply removes the problematic bundles from the search patch altogether.

[maltewi]

The probem is occuring to other people as well. The suggested solution so far worked for them. Maybe merge for now and, if the solution is not quite perfect, open an issue for improvements?

[doudou]

Agreed and done