Skip to content

strip monotonic clock#287

Open
iikira wants to merge 1 commit into
robfig:masterfrom
iikira:master
Open

strip monotonic clock#287
iikira wants to merge 1 commit into
robfig:masterfrom
iikira:master

Conversation

@iikira

@iikira iikira commented Feb 21, 2020

Copy link
Copy Markdown

https://golang.org/pkg/time/#hdr-Monotonic_Clocks

Use monotonic clock may not accurately measure elapsed time.

@robfig

robfig commented Feb 29, 2020

Copy link
Copy Markdown
Owner

I don't understand the purpose or effect of your change. And all changes require unit tests. Can you explain what you are trying to accomplish? Thanks

@iikira

iikira commented Mar 2, 2020

Copy link
Copy Markdown
Author

I run this code on my Android device, doing something between 6am and 10pm.

package main

import (
	"log"

	"github.com/robfig/cron/v3"
)

func main() {
	c := cron.New()
	c.AddFunc("*/1 6-22 * * *", func() {
		// do something
		log.Println()
	})
	c.Run()
}

The running result is not correct. For example, the task stop running at 22:59:00, but task didn't run at 6:00:00 currectly in the next day. The task delayed for several hours, may running at 2pm, or 11pm.

But running this code on my Linux server, the result is correct.

I think it was mainly caused by using monotonic clocks to mesure time. In some devices, such as mobile phone, laptop, the operation system may go to sleep, and the monotonic clocks will stop.

yulefox added a commit to yulefox/cron that referenced this pull request Dec 15, 2020
@yulefox yulefox mentioned this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants