test: set up Playwright e2e with base64 specs#19
Conversation
Add @playwright/test as the e2e runner. Config auto-starts `vp dev` (port 15036) and reuses a running server. First suite covers the Base64 tool end-to-end: encode, decode, URL-safe padding, invalid-input error, and input persistence across reload. Wire e2e + playwright.config.ts into tsconfig.node so they typecheck, add the `test:e2e` script, ignore Playwright artifacts, and stop Oxfmt from parsing generated plan HTML. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR adds Playwright E2E test infrastructure with configuration and dependencies, introduces a Base64 tool test suite exercising encoding, decoding, URL-safe variants, error handling, and state persistence, and updates the build formatter to exclude generated plan files from formatting. ChangesE2E Testing Infrastructure and Base64 Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
devbox | 348db3b | Commit Preview URL Branch Preview URL |
Jun 03 2026, 03:57 PM |
#19 added Playwright, so the skill's "no e2e harness exists" branch was false and would mislead the agent into setting up a duplicate Vitest harness. Make Playwright the established path; keep no-harness as a generic future fallback. (CodeRabbit, PR #20) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Bootstraps end-to-end testing with @playwright/test and adds the first suite.
playwright.config.ts—testDir: e2e,baseURLon port 15036, auto-startsvp devand reuses an existing server.e2e/base64.e2e.ts— 5 specs for the Base64 tool: encode, decode, URL-safe padding strip, invalid-base64 error state, input persistence across reload.test:e2escript (vp run test:e2e/pnpm exec playwright test).tsconfig.node.jsonincludese2e+playwright.config.tsso they typecheck..gitignorefor Playwright artifacts;fmt.ignorePatternsso Oxfmt skips generated plan HTML.Why
No e2e coverage existed (
e2e/was empty). This wires up the real-browser flow that unit tests can't cover, starting with the only implemented module.Verification
pnpm exec playwright test→ 5 passedtsc -b→ cleanvp check→ 0 lint/type errors🤖 Generated with Claude Code
Summary by CodeRabbit
Tests
Chores