Skip to content

feat(frontend): logs uplift#4504

Open
jog1t wants to merge 1 commit into03-24-feat_frontend_bring_back_the_rivet_computefrom
03-25-feat_frontend_logs_uplift
Open

feat(frontend): logs uplift#4504
jog1t wants to merge 1 commit into03-24-feat_frontend_bring_back_the_rivet_computefrom
03-25-feat_frontend_logs_uplift

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 25, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Mar 25, 2026

🚅 Deployed to the rivet-pr-4504 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 25, 2026 at 2:42 am
website 😴 Sleeping (View Logs) Web Mar 25, 2026 at 1:28 am
frontend-inspector 😴 Sleeping (View Logs) Web Mar 25, 2026 at 1:27 am
kitchen-sink ❌ Build Failed (View Logs) Web Mar 25, 2026 at 1:21 am
mcp-hub ✅ Success (View Logs) Web Mar 25, 2026 at 1:19 am
ladle ❌ Build Failed (View Logs) Web Mar 25, 2026 at 1:19 am

@jog1t jog1t mentioned this pull request Mar 25, 2026
11 tasks
Copy link
Contributor Author

jog1t commented Mar 25, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review March 25, 2026 01:18
@claude
Copy link

claude bot commented Mar 25, 2026

PR Review: feat(frontend): logs uplift

Overall this is a clean, well-scoped frontend feature. A few observations below.

Icon Package Build Refactor

The deletion of `dist/index.gen.js` (79K lines) is the bulk of the diff. The build script now renames the bundled output to `index.js` directly rather than going through an intermediate `index.gen.js`. This is a clean improvement.

Note: two Railway builds are failing (`kitchen-sink` and `ladle`). Worth confirming these are not related to the icon rename.

currentNamespaceHasManagedPoolQueryOptions

The "has managed pool" check uses `select: (data) => !!data?.config.image`. This ties tab visibility to whether the pool has an image configured, not just whether it exists. If a pool is created but has not had an image set yet, the Deployment Logs tab will be hidden even though the pool is real. Confirm this is intended — if the goal is "pool exists", a simpler `!!data` check may be more correct.

Deployment Logs: logfmt parsing

`parseMessage()` calls `logfmt.parse()` without guarding against exceptions. The parser is tolerant of malformed input, but if a log line causes it to throw, the entire `LogRow` render would crash. Consider wrapping in a try/catch to fall back to rendering the raw message.

Deployment Logs: column width measurement

The `useColWidths` hook measures the widest-seen timestamp/region via DOM refs and updates CSS custom properties. On cold start (before any rows are measured), columns may shift once the first logs land. If there is visible jank, a sensible `min-width` default on header cells matching expected character widths would stabilize the initial layout.

Console tab promotion

Moving the console from an always-visible panel into a proper tab is a good UX simplification. `ActorConsoleFull` is a clean, minimal export.

URL search param persistence

Persisting the search filter in the URL is a nice UX improvement (bookmarkable, shareable).

Minor

  • No tests cover the new logfmt parsing logic. `logfmt.ts` handles edge cases (quoted strings, JSON-embedded values, boolean coercion) that would benefit from unit tests.
  • The PR description is empty — worth filling in for reviewers and future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant