feat(frontend): logs uplift#4504
feat(frontend): logs uplift#4504jog1t wants to merge 1 commit into03-24-feat_frontend_bring_back_the_rivet_computefrom
Conversation
|
🚅 Deployed to the rivet-pr-4504 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: feat(frontend): logs upliftOverall this is a clean, well-scoped frontend feature. A few observations below. Icon Package Build Refactor The deletion of `dist/index.gen.js` (79K lines) is the bulk of the diff. The build script now renames the bundled output to `index.js` directly rather than going through an intermediate `index.gen.js`. This is a clean improvement. Note: two Railway builds are failing (`kitchen-sink` and `ladle`). Worth confirming these are not related to the icon rename. currentNamespaceHasManagedPoolQueryOptions The "has managed pool" check uses `select: (data) => !!data?.config.image`. This ties tab visibility to whether the pool has an image configured, not just whether it exists. If a pool is created but has not had an image set yet, the Deployment Logs tab will be hidden even though the pool is real. Confirm this is intended — if the goal is "pool exists", a simpler `!!data` check may be more correct. Deployment Logs: logfmt parsing `parseMessage()` calls `logfmt.parse()` without guarding against exceptions. The parser is tolerant of malformed input, but if a log line causes it to throw, the entire `LogRow` render would crash. Consider wrapping in a try/catch to fall back to rendering the raw message. Deployment Logs: column width measurement The `useColWidths` hook measures the widest-seen timestamp/region via DOM refs and updates CSS custom properties. On cold start (before any rows are measured), columns may shift once the first logs land. If there is visible jank, a sensible `min-width` default on header cells matching expected character widths would stabilize the initial layout. Console tab promotion Moving the console from an always-visible panel into a proper tab is a good UX simplification. `ActorConsoleFull` is a clean, minimal export. URL search param persistence Persisting the search filter in the URL is a nice UX improvement (bookmarkable, shareable). Minor
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: