Skip to content

Use bench-helper package#32

Merged
timohanke merged 1 commit into
mainfrom
rc-0.4.6
Mar 18, 2026
Merged

Use bench-helper package#32
timohanke merged 1 commit into
mainfrom
rc-0.4.6

Conversation

@timohanke
Copy link
Copy Markdown
Contributor

@timohanke timohanke commented Mar 18, 2026

Summary by CodeRabbit

  • New Features

    • Benchmarking infrastructure now leverages the faster Array implementation from core modules, providing more accurate performance metrics and significantly improved testing speed
  • Dependencies & Toolchain

    • Version updated to 0.4.6
    • Integrated bench-helper package to enhance benchmarking capabilities and testing infrastructure
    • Updated development toolchain (moc 1.1.0 → 1.3.0) and core dependencies for better compatibility, performance, and stability

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1644485-a64f-4b5e-9d07-03d55df2db00

📥 Commits

Reviewing files that changed from the base of the PR and between cd9c38a and 9de69a2.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • bench/vector-sort.bench.mo
  • bench/vector.bench.mo
  • mops.toml
  • src/lib.mo

📝 Walkthrough

Walkthrough

This PR migrates the project from local benchmark type definitions to the external mo:bench-helper package and updates library imports from mo:base/ to mo:core/. The version is bumped to 0.4.6, dependencies are updated accordingly, and a minor variable binding change is made in the core library.

Changes

Cohort / File(s) Summary
Benchmark Migration
bench/vector-sort.bench.mo, bench/vector.bench.mo
Replaced local BenchV1 type and Schema with external Bench.V1 and Bench.Schema; updated imports from mo:base to mo:core and added mo:bench-helper; refactored method calls (e.g., Nat.toText → toText()).
Configuration
mops.toml
Version bumped to 0.4.6; dev-dependencies updated: removed bench, added core and bench-helper; moc toolchain updated from 1.1.0 to 1.3.0.
Documentation
CHANGELOG.md
Added version 0.4.6 entry documenting bench-helper package usage and Array comparison against core module.
Core Library
src/lib.mo
Changed last_data_block from mutable (var) to immutable (let) binding in removeLast function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Improve benchmark accuracy #31: Introduces the initial BenchV1 and Schema types locally, which this PR replaces with the external Bench.V1 and Bench.Schema from mo:bench-helper.
  • Maintenance #30: Updates project manifest and changelog for version bumping and dependency migration to mo:core/bench variants.

Poem

🐰 From local types we hop away,
To bench-helper's external way!
With mo:core in every sight,
Our benchmarks run much faster, bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Use bench-helper package' directly and clearly describes the primary change across the PR — migrating the benchmark files from using internal implementations to using the external bench-helper package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rc-0.4.6
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

@timohanke timohanke merged commit 72951be into main Mar 18, 2026
2 checks passed
@timohanke timohanke deleted the rc-0.4.6 branch March 18, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant