Add slot attribute to JsxDom props#7402
Add slot attribute to JsxDom props#7402hellos3b wants to merge 1 commit intorescript-lang:masterfrom
Conversation
|
Hello, thanks for this contribution! Could you run: to update the failing test! |
|
@nojaf Dang yeah thought I could get away with git editor. Will get things set up and do it more properly |
|
No worries! Just a quick tip for next time: please use a different branch for your PR if possible. I fixed this locally, but I wasn't able to push to your branch since it is the default one. |
|
@nojaf I may need to resubmit off a new branch, went through // @
fs.writeFileSync(lockFileName, ownerProcess.pid.toString(), { |
|
Are you using the right node version? |
|
This was done in #7487, thanks for pushing for this! |
This adds the
slotattribute to the JsxDom props which is commonly used in web component libraries that use the shadow dom.MDN Reference
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/slot
Sample
Workaround
Have been using this as a workaround for a while before I realized I can contribute myself