Skip to content

move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react#151

Draft
dkirchhof wants to merge 2 commits intorescript-lang:masterfrom
dkirchhof:add-domprops-and-domstyles
Draft

move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react#151
dkirchhof wants to merge 2 commits intorescript-lang:masterfrom
dkirchhof:add-domprops-and-domstyles

Conversation

@dkirchhof
Copy link

@dkirchhof dkirchhof commented Mar 7, 2026

@dkirchhof dkirchhof changed the title move JsxDOM.dromProps and JsxDOMStyle from compiler to rescript/react move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react Mar 7, 2026
@Freddy03h
Copy link
Collaborator

Hi @dkirchhof,
You bumped the version in the PR, but I think this is usually done by the maintainer directly on the master branch when releasing.
Also, maybe this change should be addressed after the ReScript 12 migration? (idk)

@dkirchhof
Copy link
Author

Hi @dkirchhof, You bumped the version in the PR, but I think this is usually done by the maintainer directly on the master branch when releasing. Also, maybe this change should be addressed after the ReScript 12 migration? (idk)

Yeah, wasn't sure about the version. Also not sure about the overall plan to migrate the domprops from the compiler repo. There are a lot of discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants