Develop Navbar#56
Merged
Merged
Conversation
Member
Inioluwa21
commented
Jun 25, 2023
Inioluwa21
commented
Closed
marmikpatel19
requested changes
Jun 26, 2023
Member
marmikpatel19
left a comment
marmikpatel19
left a comment
There was a problem hiding this comment.
Looks good for the most part. Here are a few things to change in addition to my other comments. Please reassign me to review when fixed.
A maxWidth would be good because on large screens, the logo and links are really far apart. If we have a maxWidth of like 1000px then they wouldn't go further than that. Take a look at the footer for reference.
Logo alignment for mobile is off (the logo is higher than the text unlike desktop view):
Member
marmikpatel19
left a comment
marmikpatel19
left a comment
There was a problem hiding this comment.
It doesn't seem to have fixed anything on my screen?
-
maxWifth:
-
Alignment
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.