Remove invalidate_cached_urls.

[ugisozols]

It's not needed because:

• cache is cleared by after_filter in admin pages controller
• when rebuild is called it runs #invalidate_cached_urls on every page
  and its children so in case user has many pages it causes a lot of
  queries which increases load time and sometimes even time out.

See #1954 for discussion.

[parndt]

Not too big of a change for 2-0-stable?

[ugisozols]

It's a private api so in theory it should be safe to remove/change.

Other option (probably a bit safer since we don't have specs) is to just remove find_each call in https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/models/refinery/page.rb#L193 or remove https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/models/refinery/page.rb#L191-195 altogether since there's no point to keep it in case we remove find_each.

[Matho]

We don't need to call rebuild! from awesome-nested-set ? (that alias_method_chain ) #1954 (comment) When I was testing it, my tree was allways valid, so it returned true. But is there any situations, when tree is not valid and rebuild! should run?

[ugisozols]

awesome_nested_set checks if tree is invalid and only rebuilds if it's invalid. See https://github.com/collectiveidea/awesome_nested_set/blob/master/lib/awesome_nested_set/awesome_nested_set.rb#L184-185.

Tbh I have no idea when tree can become invalid (maybe if you do some manual record editing in db or something like that).

[parndt]

I think that it's safer to merge any of this into master not 2-0-stable branch. I don't consider any of this a bug fix.

If anybody disagrees please let me know.

[ugisozols]

This code isn't present in master so it only applies to 2-0-stable.

I can agree that it's safer not to merge this in 2-0-stable but we need to do something about #1954 since it's a real issue.

[parndt]

Can we just stop calling it?

[ugisozols]

We can but then https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/models/refinery/page.rb#L191-195 is not needed anymore and since we have https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/controllers/refinery/admin/pages_controller.rb#L11 we don't need https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/models/refinery/page.rb#L444-454 which is called from https://github.com/refinery/refinerycms/blob/2-0-stable/pages/app/models/refinery/page.rb#L61-62 :)

[parndt]

@ugisozols can you please document this in the changelog?

[ugisozols]

@parndt done ^

[parndt]

Another PR in here too? :-)

[ugisozols]

I actually don't get it why it's here because I only rebased against remove_invalidate_cached_urls...

[ugisozols]

@parndt I squashed everything into one commit.

[robyurkowski]

@ugisozols does this need verification, or can it be closed, then?

[ugisozols]

If you're ok with this change please merge it.

[parndt]

Sure thing