Skip to content

Parent id nested set options#1633

Closed
thedarkone wants to merge 1 commit into
refinery:2-0-stablefrom
thedarkone:parent_id_nested_set_options
Closed

Parent id nested set options#1633
thedarkone wants to merge 1 commit into
refinery:2-0-stablefrom
thedarkone:parent_id_nested_set_options

Conversation

@thedarkone
Copy link
Copy Markdown
Contributor

Manually preload :translations association to avoid the extra queries.

@travisbot
Copy link
Copy Markdown

This pull request passes (merged 868d93d into 21ab29b).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i is the instance of page and id is nil so this produces select tree with empty values for options. Can you fix it please? Thanks!

@ugisozols
Copy link
Copy Markdown
Member

For the future - please open PR's against master branch instead of 2-0-stable. I'm asking this so that we can put new stuff in the dev branch first and only then backport needed changes/fixes to the stable branches. Thanks :)

@ugisozols
Copy link
Copy Markdown
Member

Bonus points for specs!

@thedarkone
Copy link
Copy Markdown
Contributor Author

Re-pushed, thanks for catching that!

Dev branches and specs are for sissies :).

@travisbot
Copy link
Copy Markdown

This pull request passes (merged 3e2b3ad into 21ab29b).

@ugisozols
Copy link
Copy Markdown
Member

I liked first version better because it was shorter and cleaner. All you had to do was to remove id. i already was an instance of page so you had access to page id. WDYT?

@parndt
Copy link
Copy Markdown
Member

parndt commented May 12, 2012

Merged. Specs are for people who want to ensure that we don't break your code later ;-)

@parndt
Copy link
Copy Markdown
Member

parndt commented May 12, 2012

Oh, and I merged it to master and with e4c0aae and c8dabae

@parndt
Copy link
Copy Markdown
Member

parndt commented May 12, 2012

Opened #1653 for 2-0-stable

@parndt parndt closed this May 12, 2012
ugisozols added a commit that referenced this pull request May 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants