Conversation
Contributor
Author
|
...to clarify, the issue, not the fix, will cause issues. (p'arndt) |
Member
There was a problem hiding this comment.
Would you care to refactor this entire condition? It's really confusing.
Member
There was a problem hiding this comment.
Plus I think we should consider using && instead of and. What do you think?
Contributor
Author
There was a problem hiding this comment.
Definitely on the last, and I'm going to reformat it, if not refactor it — I'm not really sure how you would make it more concise.
Contributor
Author
|
Ah, sorry, guys, I've been asleep. Nice catches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause issues in exceedingly rare circumstances.