Skip to content

fix: resolve easy TODOs and doc issues#571

Merged
prestwich merged 3 commits intorecmo:mainfrom
DaniPopes:dani/fix-easy-todos
Apr 23, 2026
Merged

fix: resolve easy TODOs and doc issues#571
prestwich merged 3 commits intorecmo:mainfrom
DaniPopes:dani/fix-easy-todos

Conversation

@DaniPopes
Copy link
Copy Markdown
Contributor

@DaniPopes DaniPopes commented Apr 21, 2026

Closes #545 - const_eq counter-based implementation for ~200 cycle improvement on x86_64
Closes #349 - Fix incorrect panic doc on Matrix::from_u64 (said r0 < r1, should be r1 > r0)
Closes #323 - Remove stale // TODO: document algorithms from #![allow(missing_docs)] (unstable internal module, allow is intentional)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 21, 2026

Merging this PR will improve performance by 11.04%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 383 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
most_significant_bits/4096/4096 28.9 µs 26.1 µs +11%
to/f32/4096 29.1 µs 26.3 µs +10.97%
to/f64/4096 29.3 µs 26.4 µs +11.04%

Comparing DaniPopes:dani/fix-easy-todos (062b991) with main (a21eb25)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (062b991) during the generation of this report, so a21eb25 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

- perf(cmp): use counter-based const_eq for better x86_64 codegen
- docs(gcd): fix incorrect panic doc on Matrix::from_u64
- chore: remove stale TODO suffix from missing_docs allow
- chore: justify clippy::similar_names allow with paper reference
@DaniPopes DaniPopes force-pushed the dani/fix-easy-todos branch from 7c48e46 to 96c32be Compare April 21, 2026 22:40
@DaniPopes DaniPopes marked this pull request as ready for review April 21, 2026 22:40
@DaniPopes DaniPopes requested a review from prestwich as a code owner April 21, 2026 22:40
@prestwich prestwich enabled auto-merge April 23, 2026 18:50
@prestwich prestwich merged commit a21eb25 into recmo:main Apr 23, 2026
18 checks passed
@DaniPopes DaniPopes deleted the dani/fix-easy-todos branch April 23, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants