Fix Image Lightbox not working with CMS images#75
Open
bencounsell wants to merge 1 commit intomainfrom
Open
Conversation
Fixes #72 The lightbox template expects 'srcset' property on the lightImage object, but this property was not being set for CMS images. This caused the lightbox to not display the correct image when using CMS image sources. The fix ensures that srcset is properly set to the baseSrc from the responsive image data for both light and dark mode CMS images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the lightbox feature on the Image component when the image source is set to CMS. The lightbox image was not being set correctly for CMS images.
Fixes #72