Add PHPStan to test environment with max level#180
Merged
WyriHaximus merged 2 commits intoreactphp:3.xfrom Jun 3, 2024
Merged
Conversation
SimonFrings
approved these changes
May 22, 2024
Member
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
I went over all changes made, looks good to me 👍
WyriHaximus
reviewed
May 23, 2024
WyriHaximus
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds PHPStan on
maxlevel to the test environment for all supported PHP versions as discussed in #173. It runs the maximum level supported with all errors addressed without having to resort to a baseline. The changeset size seems reasonable and this does not other affect our public API, so this should be safe to apply.Builds on top of #178, #177, #175, #174, #172 and reactphp/async#76