Add new SocketServer and deprecate Server to avoid class name collisions#263
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Jul 27, 2021
Merged
Add new SocketServer and deprecate Server to avoid class name collisions#263WyriHaximus merged 1 commit intoreactphp:masterfrom
SocketServer and deprecate Server to avoid class name collisions#263WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
SocketServer and deprecate Server to avoid class name collisions
WyriHaximus
approved these changes
Jul 27, 2021
This was referenced Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds a new
SocketServerclass as a replacement for theServerclass to avoid class name collisions and ambiguities.The new
SocketServerclass has been added with an improved constructor signature as a replacement for the previousServerclass in order to avoid any ambiguities. The previous name has been deprecated and should not be used anymore. In its most basic form, the deprecatedServercan now be considered an alias for newSocketServer. Existing code continues to work as-is.Builds on top of reactphp/http#417 and #260