Closed
Conversation
Member
|
@andig tagged it work in progress as long as you're working on it 👍 . Personally I don't really care if it takes a few minutes longer to include as we rarely respond within that time 😄 . |
Contributor
Author
|
@WyriHaximus got the build working, see https://travis-ci.org/reactphp/socket/jobs/285066497 |
Member
|
@andig awesome <3! Could you squash the commits? |
Contributor
Author
|
Will do when my mac has survived the highSierra update. Or you can squash on merge in GitHub! |
Member
|
Hah true good point 👍 |
Contributor
Author
See my update there. Some tests are flaky. |
clue
pushed a commit
to clue-labs/stream
that referenced
this pull request
Oct 9, 2017
Squashed by @clue, originally from reactphp/socket#124
clue
pushed a commit
to clue-labs/socket
that referenced
this pull request
Oct 22, 2017
Squashed by @clue, originally from reactphp#124
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports #121 (comment), also added PHP 7.0/7.1 individually. The downside is that OSX build resources are scarce and this will increase build times.
Doesn't work yet, will try some fiddling. Please ignore for time being.