Merged
Conversation
Member
|
@jorrit Good catch 👍 The HHVM build is currently failing in all ReactPHP components because Composer 2.3 does not longer support legacy PHP or legacy HHVM. @clue and I discussed the whole topic and came up with a fix: reactphp/socket#289. I will fill in PRs that fix the same issue across the other components (and in here). After that I we will come back to this ticket, shouldn't take long. |
WyriHaximus
approved these changes
Apr 12, 2022
Member
|
@SimonFrings Honestly, this is a non-code change. The failing pipeline is irrelevant and we have no reason to wait for it to be fixed and can just merge this in as is. |
Member
|
@WyriHaximus Fine by me 👍 |
SimonFrings
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.