Introduce using PSR-7 HTTP Status code constants#406
Closed
WyriHaximus wants to merge 1 commit intoreactphp:masterfrom
WyriHaximus-labs:introduce-http-status-code-constants
Closed
Introduce using PSR-7 HTTP Status code constants#406WyriHaximus wants to merge 1 commit intoreactphp:masterfrom WyriHaximus-labs:introduce-http-status-code-constants
WyriHaximus wants to merge 1 commit intoreactphp:masterfrom
WyriHaximus-labs:introduce-http-status-code-constants
Conversation
Member
|
Would it make sense to use constants from Fig\Http\Message\StatusCodeInterface? |
Member
Author
|
@jsor How did I not know those are out there?! Updating the PR now |
WyriHaximus
changed the title
Introducing using these constants makes it easier to identify a specific HTTP status used in our code. And for our users to use readable status codes in their own code.
jsor
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing using these constants makes it easier to identify a
specific HTTP status used in our code. And for our users to use
readable status codes in their own code.