chore(docs): remove leading dollar sign#155
chore(docs): remove leading dollar sign#155nhedger wants to merge 1 commit intoreactphp:masterfrom nhedger:chore/remove-dollar-sign
Conversation
|
Made sense to me because the first code block gives instructions to install the new |
WyriHaximus
left a comment
There was a problem hiding this comment.
We can still remove it here to be honest. It won't hurt anyone :).
|
I don't have any strong opinions on this one and I'm still not sure what to do about this PR, but I'm currently leaning towards not maintaining this component anymore as per #152/#153. GitHub prominently features the date the project and individual files have been last updated, so I feel merging this PR might come over as this project being "resurrected". I'd rather convey the fact that this project is in fact "dead" prominently. It's my understanding that if we accept this PR, there's reason to believe we should do more housekeeping for this project, like updating the failing test suite and more. Even if we don't do this ourselves, there's a chance somebody else might look into this and reasonably ask for a PR review. Personally, I'd rather spend time on working the current HTTP component instead. |
|
I agree. Wouldn't it make sense to archive the repository in that case ? |
See reactphp/http#458