Conversation
WyriHaximus
force-pushed
the
rewrite
branch
2 times, most recently
from
9e4fc37 to
7be39ff
Compare
WyriHaximus
force-pushed
the
rewrite
branch
2 times, most recently
from
5e6f62c to
6eb3c14
Compare
WyriHaximus
force-pushed
the
rewrite
branch
5 times, most recently
from
7a1615c to
e34ce17
Compare
|
@clue @SimonFrings This PR is now fully ready for review. The green build can be found here. And a readable render of the readme here. |
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
I looked over everything and focused on writing and syntax because functional adjustments can always be done in following PRs. If the tests are green, then I am happy ^^
Still some work to do but this is definitely a better version than before, nice work @WyriHaximus 👍
|
@SimonFrings Thanks! Just updated this PR with your suggestions 👍 |
This is a full rewrite of this package including the following features/changes: * ext-uv adapter * child process adapter * fallback (blocking) adapter (for native Windows) * simplified the internals to remove unnecessary complexity * file_get_contents/file_put_contents like API to read/write from/to files * start has become an object instead of an array This PR doesn't include the following features/changes as those will be added in with followup PR's: * ext-eio adapter * macos support * mode support to define permissions when creating files/directories * symlinks read/creating/deleting * deleting of directories
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Let's get this shipped! 
I agree with everything that's been said, so I only briefly eyeballed this. This may not be perfect (yet), but it's definitely a major improvement over the current experimental filesystem implementation. Let's get this in as-is and build on top of this with future PRs 👍
|
@clue 🚢 🇮🇹 !
Already on it! #99 |
5 participants
This is a full rewrite of this package including the following features/changes:
This PR doesn't include the following features/changes as those will be added in with followup PR's:
cc: @SimonFrings