StreamSelectLoop: Fix erroneous zero-time sleep#49
Closed
joshdifabio wants to merge 1 commit intoreactphp:masterfrom
Closed
StreamSelectLoop: Fix erroneous zero-time sleep#49joshdifabio wants to merge 1 commit intoreactphp:masterfrom
joshdifabio wants to merge 1 commit intoreactphp:masterfrom
Conversation
Member
|
Nice find 👍 |
clue
approved these changes
Jan 9, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@joshdifabio The changes LGTM 👍 Can you add some tests for this?
WyriHaximus
approved these changes
Jan 11, 2017
jsor
approved these changes
Feb 4, 2017
Member
|
Ping @joshdifabio, what do you think about adding a test here? Also, may I ask you to rebase this on the new "0.4" branch so we get this in for the upcoming v0.4.3 release? |
clue
changed the title
Author
|
I can't see an easy way to test this, but I'm also very busy and this isn't near the top of my priority list. Please feel free to close this PR and make the change yourself if that's easier. |
Member
|
Superseded by #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #48.