Conversation
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Added some small remarks below, maybe it's also a good idea to add the source where we based this PR on (friends-of-reactphp/mysql#185). Let's add this to the description so we can simply copy-paste this for the upcoming 3.x branch pull requests in our other repositories 👍
WyriHaximus
force-pushed
the
3.x-development
branch
2 times, most recently
from
6da4b30 to
a289d8f
Compare
|
@SimonFrings Updated with suggested changes
This is exactly why I haven't prepared the rest of the branches yet. Once this one is good, I'll create the rest so they can be put up once the roadmap tickets has been created. |
WyriHaximus
force-pushed
the
3.x-development
branch
from
a289d8f to
b2b8429
Compare
WyriHaximus
force-pushed
the
3.x-development
branch
from
b2b8429 to
8ab2ce8
Compare
WyriHaximus
force-pushed
the
3.x-development
branch
from
8ab2ce8 to
ff64f7a
Compare
SimonFrings
left a comment
SimonFrings
left a comment
There was a problem hiding this comment.
Thanks for applying the suggested changes, looks good to me 👍
Once this PR is merged, we can start working on the new [v3.0.0 milestone](https://github.com/reactphp/event-loop/milestone/15). The default branch will be `3.x` and the old `1.x` branch still stay in place at least until `3.0.0` is released. Refs: Road map ticket for event-loop: reactphp#271 Plans for ReactPHP v3: https://github.com/orgs/reactphp/discussions/481 PR templated from: friends-of-reactphp/mysql#185
WyriHaximus
force-pushed
the
3.x-development
branch
from
ff64f7a to
1860102
Compare
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Nice! Now let's get started! 
3 participants
Once this PR is merged, we can start working on the new v3.0.0 milestone. The default branch will be
3.xand the old1.xbranch still stay in place at least until3.0.0is released.Refs:
Road map ticket for event-loop: #271
Plans for ReactPHP v3: https://github.com/orgs/reactphp/discussions/481
PR templated from: friends-of-reactphp/mysql#185