Improve performance by using spl_object_id() on PHP 7.2+

[samsonasik]

spl_object_id() is exists since php 7.2, I think spl_object_id() can be used when php version >= 7.2

Refs:

• Implement spl_object_id(object $x) : int php/php-src#2611
• https://developer.wordpress.com/2023/08/24/speedier-php-execution-in-wordpress-6-3/

Same implementation in reactphp/http:

https://github.com/reactphp/http/blob/c6321978bfb82de979fe4dc28eb0c08bc34937ad/src/Io/RequestHeaderParser.php#L165

Benchmark

Before call in loop took: 13.639ms

https://3v4l.org/4rUL4

After call in loop took: 4.835ms

https://3v4l.org/jKtO6

[samsonasik]

it seems cause error in test:

➜  event-loop git:(use-spl-object-id) vendor/bin/phpunit tests/Timer/TimersTest.php
PHPUnit 9.6.11 by Sebastian Bergmann and contributors.

.F                                                                  2 / 2 (100%)

Time: 00:01.009, Memory: 6.00 MB

There was 1 failure:

1) React\Tests\EventLoop\Timer\TimersTest::testContains
Failed asserting that false is true.

/Users/samsonasik/www/event-loop/tests/Timer/TimersTest.php:37

FAILURES!
Tests: 2, Assertions: 2, Failures: 1.

[samsonasik]

I see, $id need to be filled on contains() method 0221e0d

[samsonasik]

CI error seems unrelated https://github.com/reactphp/event-loop/actions/runs/6026916701/job/16350927220?pr=267#step:4:88

[SimonFrings]

Hey @samsonasik, thanks for your contribution 👍

I can see from your benchmark that using the spl_object_id() seems to be way more efficient than spl_object_hash(). I'm curious if this also offers some performance improvements for this project, do you have some benchmarks using ReactPHP?

CI error seems unrelated

Regarding the CI error, the pecl/uv extension received a new v0.3.0 in June which is only compatible with 8+ (for reference see: https://pecl.php.net/package/uv) . I'll have a look at this 👍

[samsonasik]

Hi, we are using event-loop at rector, we use spl_object_id and it seems improve the performance, see related PR:.

• [Performance] Use more performance spl_object_id() rectorphp/rector-src#4876
• micro: use spl_object_id() phpstan/phpstan-src#2592
• micro-optimization: use spl_object_id() instead of spl_object_hash() Roave/BetterReflection#1364

[samsonasik]

@SimonFrings rebased 👍

[samsonasik]

All green 🎉

[clue]

@samsonasik Thank you for looking into this and filing this PR! 👍

The changes LGTM and while I do not expect any significant changes in real-world use cases, I can confirm this does indeed improve performance slightly in some synthetic benchmarks:

$ time php examples/92-benchmark-timers.php 1000000
# new: ~3.2s
# old: ~4.1s

Interestingly, I've also applied somewhat similar changes with reactphp/http#467 in the past.

May I ask you to squash your changes into a single commit so we can go ahead with this one?

[samsonasik]

@clue I've squashed the changes into single commit 👍

[clue]

@samsonasik Thanks for the update, changes LGTM! Keep it up!

[WyriHaximus]

@samsonasik Much appreciate putting the time and effort in this improvement 👍

[SimonFrings]

Nice work 👍