Skip to content

Completeness check + web search feature#65

Merged
adamjohnwright merged 20 commits intomainfrom
completeness-websearch
Jan 21, 2025
Merged

Completeness check + web search feature#65
adamjohnwright merged 20 commits intomainfrom
completeness-websearch

Conversation

@GFJHogue
Copy link
Copy Markdown
Collaborator

@GFJHogue GFJHogue commented Jan 20, 2025

New Features:

  • Added Tavily web search workflow for incomplete chat answers - adapted from @heliamoh's prototype code.
    • Runs as the postprocess node of the main graph.
    • Custom JSX element to show results with domain & text preview.
  • Feature enable/disable and user permissions (all, logged_in) configurable in config.yml.

Fixes / Improvements:

  • Organized growing util.config_yml module code.
  • Other minor code formatting.

@GFJHogue GFJHogue self-assigned this Jan 20, 2025
@GFJHogue GFJHogue marked this pull request as ready for review January 20, 2025 22:30
Comment thread bin/chat-chainlit.py
name="SearchResults",
props={"results": result["additional_content"]["search_results"]},
)
sent_message.elements = [search_results_element] # type: ignore
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chainlit's own type annotations on this make it seemingly impossible to satisfy mypy here.

Copy link
Copy Markdown
Contributor

@adamjohnwright adamjohnwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the paths from Helia's computer I approve of this pull request.

retriever_list = []

loader = CSVLoader(
"/Users/hmohammadi/Desktop/react_to_me_github/reactome_chatbot/embeddings/openai/text-embedding-3-large/reactome/summation_csv/summations.csv"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path doesn't seam right

os.makedirs(eval_dir, exist_ok=True)

# Initialize RAG Chain
embeddings_directory = "/Users/hmohammadi/Desktop/react_to_me_github/reactome_chatbot/embeddings/openai/text-embedding-3-large/reactome/Release90/summations"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too--this path does not seam right to be pulling in.

@adamjohnwright adamjohnwright merged commit d8195e9 into main Jan 21, 2025
@adamjohnwright adamjohnwright deleted the completeness-websearch branch January 21, 2025 20:17
GFJHogue pushed a commit that referenced this pull request Apr 17, 2025
Completeness check + web search feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants