Skip to content

splitting out neo4j query functions#9

Merged
tbarbazuk merged 1 commit intomainfrom
refactor
Jan 31, 2024
Merged

splitting out neo4j query functions#9
tbarbazuk merged 1 commit intomainfrom
refactor

Conversation

@adamjohnwright
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@tbarbazuk tbarbazuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@tbarbazuk tbarbazuk merged commit f8a702b into main Jan 31, 2024
@tbarbazuk tbarbazuk deleted the refactor branch January 31, 2024 21:05
adamjohnwright added a commit that referenced this pull request Apr 29, 2026
Dependencies (#9, #10):
- Bumped pyarrow ^15→^17, python-dotenv ^1.0.1→^1.2.2, pytest ^8.4→^9.0
  to clear 17 CVEs flagged by pip-audit. Refreshing the lock cleared
  another 6 transitive vulnerabilities (urllib3, certifi, pygments,
  filelock, virtualenv).
- pytest 9 requires Python 3.10+; Python 3.9 reached EOL 2025-10-31, so
  bumped the project floor to 3.10. README and pyproject.toml updated.
- Project-dep CVEs went from 23 → 0. Remaining 6 are in pip/setuptools
  themselves (env tooling, not project deps).

Coverage (#11):
- Added pytest-cov to the unit-tier CI step with a 40% floor (current
  unit coverage is 44%). The floor is intentionally below current to
  avoid false-positive failures on small reorganizations; it acts as a
  regression bar, not a target. Higher floors are warranted once the
  database/integration tiers can run in CI.

Reactome version tracking (#12):
- Bumped docker-compose Neo4j image Release94 → Release96 (the version
  the validation suite was actually run against — the old tag was drift).
- Added tests/test_reactome_version.py: a database-tier sentinel that
  reads the loaded Neo4j's DBInfo.version and prints it into the test
  log. Doesn't pin to a specific version; just records what each run
  used so a Reactome-correlated regression is easy to spot.
- Documented the upgrade workflow in README ("Tracking new Reactome
  releases" subsection) so bumping the image tag and re-running the
  database tier is the documented path forward.

CI hygiene:
- actions/checkout v3→v4, actions/setup-python v4→v5 in both workflows.
- ruff workflow Python 3.9→3.12 (matches test.yml).
- src/ ruff and mypy still clean; the existing tests/ ruff issues are
  pre-existing and not blocking (CI ruff job only checks src/ and bin/).
- Fixed 3 small ruff issues in bin/ scripts (unused import,
  no-placeholder f-strings).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants