Merged
Conversation
Member
|
|
Nkzn
force-pushed
the
thinking-in-react-ja
branch
from
5837532 to
86f8072
Compare
Nkzn
force-pushed
the
thinking-in-react-ja
branch
from
bb8d618 to
930c87d
Compare
smikitky
requested changes
Feb 4, 2019
Member
smikitky
left a comment
smikitky
left a comment
There was a problem hiding this comment.
こちらで確認をお願いします。全体に「あなた」が他の記事より多用されていたため、減らして簡潔な表現に寄せたりしています。
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Author
|
suggested change同士でコンフリクトした場合の対応ってどうしたらいいんでしょう・・・（いくつかoutdatedになってしまった） |
Member
|
妥当だと思われる文章で普通に手でコミットしていただけると。 |
Author
smikitky
approved these changes
Feb 5, 2019
Member
|
私はこれで大丈夫そうです |
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>
Author
|
@koba04 すいませんでした・・・！！！！！！！ |
koba04
approved these changes
Feb 5, 2019
Member
|
@Nkzn ありがとうございます！マージしました 🎉🎉🎉 |
Author
|
ありがとうございました🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation for Thinking in React.
#4