translation: SyntheticEvent#66
Conversation
ps0305
requested review from
bvaughn and
tesseralis
and removed request for
tesseralis
|
Deploy preview for hi-reactjs ready! Built with commit 374b838 |
|
Sorry, I can't review this. I don't speak Hindi. 😄 |
|
@bvaughn never too late to learn? ;) |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great start.
I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process
updated reference-event.md
updated as marked, can go ahead and review further. |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Good going.
Added review for rest of the file. Once these are fixed, it will be good to go from my end.
Update reference-events.md
There was a problem hiding this comment.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
-------EDIT-----
Sorry about this. by mistake selected Request Changes
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
arshadkazmi42
added
2nd Review
|
added comments till {#supported-events} |
Update reference-events.md
|
@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review? |
|
|
added a few more comments |
Update reference-events.md
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
added comments till {#mouse-events}
content/docs/reference-events.md
Outdated
| ## समर्थित इवेंट्स {#supported-events} | ||
|
|
||
| React normalizes events so that they have consistent properties across different browsers. | ||
| React इवेंट्स को सामान्य करता है ताकि उनके विभिन्न ब्राउज़रों में सुसंगत गुण हों। |
There was a problem hiding this comment.
सामान्य could be left as is since the translation changes the meaning
There was a problem hiding this comment.
normalizes is different than normal?
There was a problem hiding this comment.
I meant for it to read normalizes, not सामान्य and not नार्मल . Either in english/hindi works
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
added comments till {#selection-events}
Update reference-events.md
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
Just a couple of feedback points and this will be good to merge 🎆
Update reference-events.md
|
great work 👍 |
4 participants
Hindi Translation Progress #1
Translation for API Reference => SyntheticEvent