[Translation] Hooks at a Glance#58
Conversation
gautam-pahuja
changed the title
|
Deploy preview for hi-reactjs ready! Built with commit 078e2d0 |
|
Deploy preview for hi-reactjs ready! Built with commit 5cf6c53 |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great start.
Added comments till line 39.
Can you work on the fixes and we will continue with the review post these fixes
@arshadkazmi42 |
@arshadkazmi42 |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Added some more review till line 155
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work with fixes.
Added some more suggestions and replied on few comments
|
@gautam-pahuja added one more comment |
@arshadkazmi42 Please take a look when you have time. |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work.
Added review for rest of the files. Its good to go from my end once these are fixed
|
@arshadkazmi42 Pushed the changes requested. |
|
@gautam-pahuja added some more comments |
|
@arshadkazmi42 pushed changes. |
|
@gautam-pahuja just one more to go. |
|
@saranshkataria it's been more than a month, do you have anything more to review in this PR? |
|
@arshadkazmi42 any updates needed on this one? It's been lying here for months. |
@saranshkataria will be looking into this from my side its already approved |
|
@gautam-pahuja sorry I had been a bit occupied with other things. Reviewing from where I left off and adding comments |
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
Added comments till {#rules-of-hooks}
|
@saranshkataria added changes mentioned. |
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
added comments till line 177
|
@saranshkataria added changes mentioned. |
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
added comments till {#other-hooks}
|
@saranshkataria done. |
saranshkataria
left a comment
saranshkataria
left a comment
There was a problem hiding this comment.
added final set of changes. So close 🔥
|
@saranshkataria Changes added 😄 |
|
Merged in. Thanks 🎆 🥳 |
|
Thanks a lot for all the efforts @saranshkataria and @arshadkazmi42 👍 |
3 participants
No description provided.