added translations for Babel, JSX, and Build Steps#50
Merged
arshadkazmi42 merged 2 commits intoreactjs:masterfrom Oct 3, 2019
Merged
added translations for Babel, JSX, and Build Steps#50arshadkazmi42 merged 2 commits intoreactjs:masterfrom
arshadkazmi42 merged 2 commits intoreactjs:masterfrom
Conversation
shobhitsingh29
changed the title
Babel, JSX, and Build Steps
shobhitsingh29
changed the title
|
Deploy preview for hi-reactjs ready! Built with commit 25188a6 |
88 tasks
Contributor
Author
|
@arshadkazmi42 can you review this 😄 |
arshadkazmi42
requested changes
Oct 3, 2019
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Thank you for taking this up.
I have left couple of feedbacks.
Once those are fixed, its good to go from my end
Contributor
Author
|
@arshadkazmi42 done with review comments |
arshadkazmi42
approved these changes
Oct 3, 2019
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Looks good 💯
Thank you for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before :
After :