Condition rendering fixed updated final#43
Condition rendering fixed updated final#43kambleaa007 wants to merge 28 commits intoreactjs:masterfrom kambleaa007:conditionRendering
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit 19132f8 |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Reviewed till 124.
There are still few feedbacks are pending which were not fixed in the previous PR and I have added a few more feedbacks
Let's get those fixed then I will continue the review further
|
@kambleaa007 There is two left from previous feedback. Lets get those fixed and then we can continue with rest of the review |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Done with review.
Once you fix all the feedbacks it will be good to go from my end for second review
ready to go for second review
|
@kambleaa007 Great work. |
Who will be the second reviewer ? |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work 💯
Thank you for your patience and working on the feedbacks.
Review is done from my end.
For next steps @saranshkataria will be doing second review for this.
Thanks @arshadkazmi42 for guiding me!! |
|
I'll start looking into this soon. Sorry for the delay! |
|
@saranshkataria I guess, Your approval is pending |
| @@ -44,13 +43,13 @@ ReactDOM.render( | |||
|
|
|||
| [**Try it on CodePen**](https://codepen.io/gaearon/pen/ZpVxNq?editors=0011) | |||
There was a problem hiding this comment.
this needs to be translated too
There was a problem hiding this comment.
इसे CodePen पर आज़माएँ makes more sense
| आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा। | ||
|
|
||
| Consider these two new components representing Logout and Login buttons: | ||
| अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो : |
There was a problem hiding this comment.
not the right translation
There was a problem hiding this comment.
लॉगिन और लॉगआउट बटन्स के नए कौम्पोनॅन्टस पर विचार करें
There was a problem hiding this comment.
लॉगआउट और लॉगिन बटन्स का प्रतिनिधित्व करने वाले इन दो नए कौम्पोनॅन्टस पर विचार करें:
|
added comments till line 70 |
Reviewed done
| @@ -44,13 +43,13 @@ ReactDOM.render( | |||
|
|
|||
| [**Try it on CodePen**](https://codepen.io/gaearon/pen/ZpVxNq?editors=0011) | |||
| आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा। | ||
|
|
||
| Consider these two new components representing Logout and Login buttons: | ||
| अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो : |
There was a problem hiding this comment.
लॉगिन और लॉगआउट बटन्स के नए कौम्पोनॅन्टस पर विचार करें
| आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा। | ||
|
|
||
| Consider these two new components representing Logout and Login buttons: | ||
| अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो : |
|
return Welcome back!; and returnPlease sign up.;on lines18 and 22 should be translated to hindi too |
4 participants
No description provided.