updating rendering elements from #21#41
Merged
arshadkazmi42 merged 4 commits intoreactjs:masterfrom Jul 8, 2019
Merged
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit d94a184 |
|
Deploy preview for hi-reactjs ready! Built with commit 8f1bf91 |
arshadkazmi42
requested changes
Jul 7, 2019
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Looks good.
Just a small feedback and I think its good to go from my end
content/docs/rendering-elements.md
Outdated
| ``` | ||
|
|
||
| Unlike browser DOM elements, React elements are plain objects, and are cheap to create. React DOM takes care of updating the DOM to match the React elements. | ||
| ब्राउज़र DOM एलेमेंट्स के विपरीत, React एलेमेंट्स प्लेन ऑब्जेक्ट है और इन्हें बनाना आसान है। React DOM React एलेमेंट्स के अनुसार DOM को अपडेट रखता है। |
Member
There was a problem hiding this comment.
एलेमेंट्स => एलिमेंट्स
Any thoughts?
Member
There was a problem hiding this comment.
There are few more you have missed.
I think you should do CTLR+F and Replace All
88 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.