Translating page Style and Lifecycle.#26
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit c364000 |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
This is great start
I have started the review.
I have added the feedback till line 60.
Once you are done fixing those, we can continue with a review of the next parts of the translation.
Please do go through the review process (here #23) which we follow.
You can make the suggested changes and add an 👍 emoji to acknowledge it, the reviewer will review the changes and they will resolve the feedback
1. राज्य => State 2. प्रतिक्रिया => React 3. घटक => कौम्पोनॅन्ट
|
@charBap Can you also, mark the review feedback which you have fixed using 👍 emoji |
|
@charBap Please read the comments I have been adding, it will be difficult to review if you are not reading my comments. |
|
@arshadkazmi42 I have resolved all issues that you have specified. |
|
@arshadkazmi42 Sorry my bad. |
|
@charBap Do not mark them resolved, just add a 👍 in the comments. |
|
It's just to follow a procedure, it will be easy for reviewers to keep track of the review if everyone follows the process |
|
@charBap All changes looks fine. There is just a small issue you missed, I have left a comment for that and resolved all other conversations. |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work till now.
Added few more comments, done till line 109
|
@charBap There are many feedback which are not acknowledged, can you have a look at those too |
|
@arshadkazmi42 I am doing it right now. :) |
|
@charBap There is 1 issue at line 75-76, once that is fixed, I will continue with next lines review |
arshadkazmi42
left a comment
arshadkazmi42
left a comment
There was a problem hiding this comment.
Great work.
Added some more comments.
Done till line 250
|
@charBap I have resolved most of the feedbacks, there is a couple of feedbacks which I missed in my previous review, I have added comments for those, once you are done with those we can move ahead with the review process. |
|
@charBap There is one more fix pending. |
content/docs/state-and-lifecycle.md
Outdated
| `Clock` को अब एक फ़ंक्शन के बजाय एक क्लास के रूप में परिभाषित किया गया है। | ||
|
|
||
| The `render` method will be called each time an update happens, but as long as we render `<Clock />` into the same DOM node, only a single instance of the `Clock` class will be used. This lets us use additional features such as local state and lifecycle methods. | ||
| हर अपडेट पर `render` फंक्शन कॉल होगा, लेकिन जब तक हम `<Clock />` को एक ही DOM नोड में रेंडर करते हैं, तब तक `Clock` क्लास का केवल एक ही उदाहरण इस्तेमाल किया जाएगा। इससे हम लोकल state और Lifecycle विधियों जैसी अतिरिक्त सुविधाओं का उपयोग कर सकते हैं। |
There was a problem hiding this comment.
उदाहरण -> incorrect translation
There was a problem hiding this comment.
Can you please suggest then what should go there. (Please specify in hindi)
|
done till {#adding-local-state-to-a-class} |
content/docs/state-and-lifecycle.md
Outdated
| ## क्लास में लोकल state ऐड करना {#adding-local-state-to-a-class} | ||
|
|
||
| We will move the `date` from props to state in three steps: | ||
| हम तीन चरणों में date को props से state में भेजेंगे: |
content/docs/state-and-lifecycle.md
Outdated
| ``` | ||
|
|
||
| 2) Add a [class constructor](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes#Constructor) that assigns the initial `this.state`: | ||
| 2) एक [class constructor](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes#Constructor) जोड़ें जो प्रारंभिक `this.state` को असाइन करता है: |
content/docs/state-and-lifecycle.md
Outdated
| ``` | ||
|
|
||
| Class components should always call the base constructor with `props`. | ||
| क्लास के components को हमेशा बेस कंस्ट्रक्टर को `props` के साथ कॉल करना चाहिए। |
There was a problem hiding this comment.
revisit translation too, gramatically doesn't seem right
There was a problem hiding this comment.
revisit translation too, gramatically doesn't seem right
Please suggest.
| क्लास के components को हमेशा बेस कंस्ट्रक्टर को `props` के साथ कॉल करना चाहिए। | ||
|
|
||
| 3) Remove the `date` prop from the `<Clock />` element: | ||
| 3) `<Clock />` एलिमेंट से `date` prop निकालें: |
There was a problem hiding this comment.
date prop ko kuch aise nikale
There was a problem hiding this comment.
Seems right the way it is. As "ko kuch aise nikale" is long and does not fit right.
| @@ -195,17 +196,17 @@ ReactDOM.render( | |||
|
|
|||
| [**Try it on CodePen**](https://codepen.io/gaearon/pen/KgQpJd?editors=0010) | |||
|
done till {#adding-lifecycle-methods-to-a-class} |
|
@charBap are you still working on this? |
|
Please ignore the previous commit. I tried to make a different pull request. |
|
@charBap there is no such thing as ignoring a commit, you need to undo the changes |
|
@charBap Any updates on this? Let us know if you need any help |
|
@charBap let us know if you are going to complete this, else we will be closing this PR out |
|
@arshadkazmi42 should we close this out, and wait for someone to pick it up from here, or do you want to do that? |
|
@saranshkataria Let's close this, this already have some wrong commits. We do not want to spend time on fixing that. Edit:Just checked, its almost done, let me pick this up. I will do the clean up and let's get this reviewed and merged. |
|
@saranshkataria I am seeing alot of conflicts also in this. Lets close this. We can open new PR for this page? |
|
@arshadkazmi42 Sounds good. But let's keep a track of the PR in the main issue so as to someone can pick things up from where @charBap left them and that effort does not get wasted. |
|
Closing due to inactivity |
3 participants
This pull request is in reference to translating "Style and Lifcycle" page.
#1