Add support for script nonce attributes#496
Merged
dustinsoftware merged 4 commits intoreactjs:masterfrom Feb 19, 2018
Merged
Conversation
33e9a3a to
d7b6a4f
Compare
Member
Author
|
@Daniel15 this is good to go, but I'd like another set of eyes to give it a quick look before it gets merged 😄 |
Member
Author
|
Merging this so it doesn't get stale, let me know if needs modification before shipping. Tested on Mvc4 and CoreMvc. |
Daniel15
reviewed
Mar 5, 2018
Member
Daniel15
left a comment
There was a problem hiding this comment.
Thanks. Sorry I never got to this, I think you sent it while I was on vacation.
| /// <summary> | ||
| /// Gets the site-wide configuration. | ||
| /// </summary> | ||
| IReactSiteConfiguration Configuration { get; } |
Member
There was a problem hiding this comment.
Isn't there already a getter for this? ReactSiteConfiguration.Configuration or .Current or something like that?
Member
Author
|
I can check later, the prop already existed on the implementation but not
the interface.. don’t remember seeing another one I could use
…On Sun, Mar 4, 2018 at 18:59, Daniel Lo Nigro ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks. Sorry I never got to this, I think you sent it while I was on
vacation.
------------------------------
In src/React.Core/IReactEnvironment.cs
<#496 (comment)>:
> @@ -110,5 +109,10 @@ public interface IReactEnvironment
/// Returns the currently held JS engine to the pool. (no-op if engine pooling is disabled)
/// </summary>
void ReturnEngineToPool();
+
+ /// <summary>
+ /// Gets the site-wide configuration.
+ /// </summary>
+ IReactSiteConfiguration Configuration { get; }
Isn't there already a getter for this?
ReactSiteConfiguration.Configuration or .Current or something like that?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#496 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFhWbsxbP6a5XAkSahhQRgTXl1l20ks5tbKnSgaJpZM4RdZap>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430, #482, #334