Merged
Conversation
This fixes building within VS 2017 community. node_modules can sometimes contain paths that are very long, which can trigger an msbuild bug dotnet/msbuild#406
Member
Author
|
No appveyor build? cc @Daniel15 |
Member
|
huh, I have no idea why Appveyor didn't build this. I'll try to look into that soon. |
Member
|
Strangely, the webhook to AppVeyor threw an error saying that the PR doesn't exist: I re-ran the webhook, which should kick off the AppVeyor build. Looks like it's currently queued. |
Member
|
The AppVeyor build never completed, but I feel pretty safe about this change. Let's merge it and see what happens 😛 |
|
Livin' on the edge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes building within VS 2017 community.
node_modules can sometimes contain paths that are very long, which can
trigger an msbuild bug
dotnet/msbuild#406