Added a ability to select the default JavaScript engine#413
Merged
Daniel15 merged 2 commits intoreactjs:masterfrom Jul 2, 2017
Taritsyn:master
Merged
Added a ability to select the default JavaScript engine#413Daniel15 merged 2 commits intoreactjs:masterfrom Taritsyn:master
Daniel15 merged 2 commits intoreactjs:masterfrom
Taritsyn:master
Conversation
Member
|
This seems reasonable. Could you please add a unit test for this too? |
Contributor
Author
|
Added a unit tests. |
Member
|
Thank you! |
Member
|
This is included in the 3.1 release: https://reactjs.net/2017/07/3.1.0-release.html. Thanks for your contribution, Andrey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a classic pull request, but rather a proposal to improve the React.NET. This improvement will allow to meet the expectations of following users: dima117, dgpedro, luty81, malachib, ORuban, jyee117 and mattgross76.