Merged
Conversation
rmorshea
reviewed
Jun 23, 2022
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
rmorshea
approved these changes
Jun 23, 2022
Contributor
Author
|
@rmorshea This PR is still a draft, I have a bit more to work on. I will mark as "Ready for review" when complete. |
This reverts commit 0ffb5a5.
Archmonger
commented
Jun 25, 2022
Contributor
Author
|
@rmorshea Would you have time to review this weekend? |
Contributor
|
I'll try to get to this today or tomorrow. |
Contributor
|
apologies. i will make time tomorrow |
rmorshea
requested changes
Jul 1, 2022
Contributor
rmorshea
left a comment
rmorshea
left a comment
There was a problem hiding this comment.
Just a few minor things here and there. Besides that, LGTM!
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
Contributor
Author
|
Can't merge without re-approval. |
rmorshea
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
static_csscomponent, which reads the CSS file's from disk, stores the contents in cache (for performance purposes), and then puts the file contents into ahtml.styletag.Currently, IDOM has no real way to "wait for CSS to load". This will lead to visual jank when attempting to use
html.linkto defer load CSS loading until a certain component exists. For example, visual jank occurs when usingThis also mitigates the need for the following (within Django only):
Changelog
idom-team/idom