Support for non-serializable component parameters#120
Support for non-serializable component parameters#120Archmonger merged 57 commits intoreactive-python:mainfrom
Conversation
|
@rmorshea This is fully functional but currently has no eviction/expiration strategy implemented. Let me know what you think. |
|
Will take a look tomorrow |
|
Overall LGTM. Perhaps we could add a test which passes a parameter to a component that isn't JSON serializable? |
|
The reconnect variable has been changed to better describe the new behavior. Also, the rename helps in preparation for reactive-python/reactpy#525 In the future, I hope to introduce a |
|
Changelog in the PR's description has been updated. |
|
I've added tests for the component parameter cleanup logic |
|
@rmorshea This has security fixes, so I'd like to get this out soon if possible. |
|
I removed the version bump from this PR. I will create a follow-up PR that bumps IDOM to |
|
Will review tomorrow. |
rmorshea
left a comment
There was a problem hiding this comment.
Generally approve, just few minor nits/comments
|
Let me know if we're okay with the approach on the 3 unresolved comments |
rmorshea
left a comment
There was a problem hiding this comment.
I think everything looks good to me.
Description
Functional implementation of database-backed component params
Changelog
componenttemplate tag now supports both positional and keyword arguments.componenttemplate tag now supports non-serializable arguments.manage.py migrateafter installing IDOMIDOM_WS_MAX_RECONNECT_TIMEOUThas been renamed toIDOM_RECONNECT_MAXand is now used as the default timeout for component parametersidom.backend.hookssupport.django_idom.types.IdomWebsockethas been renamed toConnectionand modified to fit the new schemaview_to_componentutility will now automatically usedel_html_head_body_transformIDOM_DEBUG_MODEtosettings.py:DEBUGdjango_query_postprocessorChecklist:
Please update this checklist as you complete each item: