[Android] vibration module by skv-headless · Pull Request #6061 · react/react-native

skv-headless · 2016-02-21T12:21:16Z

I will fix other notes from #2794 if I get positive feedback.

facebook-github-bot · 2016-02-21T12:22:20Z

By analyzing the blame information on this pull request, we identified @mkonicek, @nicklockwood and @vjeux to be potential reviewers.

eslint-bot · 2016-02-21T12:29:05Z

parameter duration Missing annotation

Please use Flow to declare it's a number.

nicklockwood · 2016-02-21T17:18:18Z

Cc: @dmmiller

mkonicek · 2016-02-21T23:45:16Z

sorry didn't understand you 😞

mkonicek · 2016-02-21T23:48:09Z

Looks good overall, thanks!

facebook-github-bot · 2016-02-22T13:57:13Z

@skv-headless updated the pull request.

eslint-bot · 2016-02-22T14:07:32Z

no-unused-vars: "invariant" is defined but never used

facebook-github-bot · 2016-02-22T14:11:14Z

@skv-headless updated the pull request.

facebook-github-bot · 2016-02-25T08:20:22Z

@skv-headless updated the pull request.

skv-headless · 2016-02-25T08:26:31Z

it is not that easy to make vibration duration in ios. I would rather make separate pr for that.

@nicklockwood http://stackoverflow.com/a/13047464/1410905 if it is good solution I can make ios vibration duration here.

facebook-github-bot · 2016-02-25T08:30:27Z

@skv-headless updated the pull request.

dmmiller · 2016-02-25T15:35:31Z

You don't need to store this separately. It is available on ReactContextBaseJavaModule via getReactApplicationContext()

dmmiller · 2016-02-25T15:39:03Z

Can we also add comments about deprecating VibrationIOS since we will now just have one Vibration API?

satya164 · 2016-02-25T15:43:07Z

Since we're adding this, it would be great to support a vibration pattern. Seems pretty simple to implement - http://developer.android.com/reference/android/os/Vibrator.html

facebook-github-bot · 2016-02-25T18:42:18Z

@skv-headless updated the pull request.

skv-headless · 2016-02-25T19:02:55Z

@dmmiller I've fixed your notes.

satya164 · 2016-02-25T21:43:48Z

@skv-headless Feel free to do it in a follow-up PR :D

facebook-github-bot · 2016-02-26T10:32:16Z

@skv-headless updated the pull request.

skv-headless · 2016-02-26T10:41:22Z

I think this PR is finished. I've already started to work on vibration patters but I'm going to create separate PR for that.

dmmiller · 2016-02-26T10:42:55Z

@facebook-github-bot shipit

dmmiller · 2016-02-26T10:45:47Z

Cool, thanks. I've asked for the bot to accept it :)

bestander · 2016-02-26T13:09:12Z

@facebook-github-bot shipit

facebook-github-bot · 2016-02-26T13:09:24Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

mkonicek · 2016-03-01T19:20:47Z

Failed to land because of failing tests. Luckily this should be easy, you just need to update BUCK files so that the code builds internally at fb where we use Buck.

See https://circleci.com/gh/facebook/react-native/3133

My guess is you just need to add a dependency here: https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/shell/BUCK

skv-headless · 2016-03-01T19:29:24Z

@mkonicek is there any instruction how to launch tests locally? I'll update tomorrow.

facebook-github-bot · 2016-03-02T18:46:32Z

@skv-headless updated the pull request.

facebook-github-bot · 2016-03-02T19:03:21Z

@skv-headless updated the pull request.

skv-headless · 2016-03-02T19:29:53Z

@mkonicek circle tests passed

dmmiller · 2016-03-02T19:48:40Z

@facebook-github-bot shipit

facebook-github-bot · 2016-03-02T19:49:25Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

skv-headless · 2016-03-03T09:41:26Z

@dmmiller if there are problems with shipping (maybe like this #6208 (comment)) I can create PR again

dmmiller · 2016-03-03T10:20:57Z

I'll get it to land. Let me commandeer the diff locally and get it in.

dmmiller · 2016-03-03T10:25:45Z

@facebook-github-bot shipit

Summary: This is a revised follow up version from #8574 ( originally implemented in `objc` ) This PR change the implementation in JS suggested by javache **motivation** To supports vibration pattern like android. The [iOS vibration implementation link](http://stackoverflow.com/questions/12966467/are-there-apis-for-custom-vibrations-in-ios/13047464#13047464) mentioned by skv-headless at #6061 (comment), which will not be accepted by apple since that implementation uses a private API. Thus, I use pure public API `NSTimer` to implement it. **Note** Since vibration time on iOS is not configurable, there are slightly differences with android. for example: **Android Usage:** `Vibration.vibrate([0, 500, 200, 500])` ==> V(0.5s) --wait(0.2s)--> V(0.5s) `Vibration.vibrate([300, 500, 200, 500])` ==> --wait(0.3s)--> V(0.5s) --wait(0.2s)--> V(0.5s) **iOS Usage:** if first argument is 0, it will not be included in pattern array. ( vibration Closes #9233 Differential Revision: D3775085 Pulled By: javache fbshipit-source-id: 370495857d5581399de32d2bed1ea1bcce193e9d

Summary: This is a revised follow up version from #8574 ( originally implemented in `objc` ) This PR change the implementation in JS suggested by javache **motivation** To supports vibration pattern like android. The [iOS vibration implementation link](http://stackoverflow.com/questions/12966467/are-there-apis-for-custom-vibrations-in-ios/13047464#13047464) mentioned by skv-headless at react/react-native#6061 (comment), which will not be accepted by apple since that implementation uses a private API. Thus, I use pure public API `NSTimer` to implement it. **Note** Since vibration time on iOS is not configurable, there are slightly differences with android. for example: **Android Usage:** `Vibration.vibrate([0, 500, 200, 500])` ==> V(0.5s) --wait(0.2s)--> V(0.5s) `Vibration.vibrate([300, 500, 200, 500])` ==> --wait(0.3s)--> V(0.5s) --wait(0.2s)--> V(0.5s) **iOS Usage:** if first argument is 0, it will not be included in pattern array. ( vibration Closes react/react-native#9233 Differential Revision: D3775085 Pulled By: javache fbshipit-source-id: 370495857d5581399de32d2bed1ea1bcce193e9d

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 21, 2016

skv-headless force-pushed the vibration-android branch from 60216b1 to 2964c4b Compare February 21, 2016 12:22

eslint-bot reviewed Feb 21, 2016
View reviewed changes

mkonicek reviewed Feb 21, 2016
View reviewed changes

skv-headless force-pushed the vibration-android branch from 2964c4b to 536053e Compare February 22, 2016 13:57

eslint-bot reviewed Feb 22, 2016
View reviewed changes

Comment thread Libraries/Vibration/Vibration.js Outdated

eslint-bot Feb 22, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-unused-vars: "invariant" is defined but never used

skv-headless force-pushed the vibration-android branch from 536053e to 0f27881 Compare February 22, 2016 14:11

skv-headless force-pushed the vibration-android branch from 4136394 to f7eb974 Compare February 25, 2016 08:19

skv-headless reviewed Feb 25, 2016
View reviewed changes

skv-headless force-pushed the vibration-android branch from f7eb974 to 5aff712 Compare February 25, 2016 08:30

dmmiller reviewed Feb 25, 2016
View reviewed changes

skv-headless force-pushed the vibration-android branch from 5aff712 to 46208a2 Compare February 25, 2016 18:41

skv-headless force-pushed the vibration-android branch from 46208a2 to 5d2bf34 Compare February 26, 2016 10:31

facebook-github-bot added GH Review: accepted and removed GH Review: review-needed labels Feb 26, 2016

skv-headless added 2 commits March 2, 2016 21:49

[Android] vibration module

970ce3c

vibration module BUCK files for tests

e48feda

skv-headless force-pushed the vibration-android branch from 1c90bcd to e48feda Compare March 2, 2016 19:02

ghost closed this in 1bab7c5 Mar 3, 2016

skv-headless mentioned this pull request Mar 10, 2016

[Android] Add support for vibration patterns #6400

Closed

zxcpoiu mentioned this pull request Jul 5, 2016

Ios: complete iOS vibration pattern supports (Objc) #8574

Closed

zxcpoiu mentioned this pull request Aug 5, 2016

Ios: complete iOS vibration pattern supports (js) #9233

Closed

This pull request was closed.

Conversation

skv-headless commented Feb 21, 2016

Uh oh!

facebook-github-bot commented Feb 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicklockwood commented Feb 21, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkonicek commented Feb 21, 2016

Uh oh!

facebook-github-bot commented Feb 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 22, 2016

Uh oh!

facebook-github-bot commented Feb 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmmiller commented Feb 25, 2016

Uh oh!

satya164 commented Feb 25, 2016

Uh oh!

facebook-github-bot commented Feb 25, 2016

Uh oh!

skv-headless commented Feb 25, 2016

Uh oh!

satya164 commented Feb 25, 2016

Uh oh!

facebook-github-bot commented Feb 26, 2016

Uh oh!

skv-headless commented Feb 26, 2016

Uh oh!

dmmiller commented Feb 26, 2016

Uh oh!

dmmiller commented Feb 26, 2016

Uh oh!

bestander commented Feb 26, 2016

Uh oh!

facebook-github-bot commented Feb 26, 2016

Uh oh!

mkonicek commented Mar 1, 2016

Uh oh!

skv-headless commented Mar 1, 2016

Uh oh!

facebook-github-bot commented Mar 2, 2016

Uh oh!

facebook-github-bot commented Mar 2, 2016

Uh oh!

skv-headless commented Mar 2, 2016

Uh oh!

dmmiller commented Mar 2, 2016

Uh oh!

facebook-github-bot commented Mar 2, 2016

Uh oh!

skv-headless commented Mar 3, 2016

Uh oh!

dmmiller commented Mar 3, 2016

Uh oh!

dmmiller commented Mar 3, 2016

Uh oh!

Reviewers

Assignees

Labels