Skip to content

do not post callback in AnimationBackendChoreographer.kt if featureflag is off #57326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
Closed

do not post callback in AnimationBackendChoreographer.kt if featureflag is off #57326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/fabric/AnimationBackendChoreographer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ package com.facebook.react.fabric
import com.facebook.proguard.annotations.DoNotStripAny
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.UiThreadUtil
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
import com.facebook.react.modules.core.ReactChoreographer
import com.facebook.react.uimanager.GuardedFrameCallback
import java.util.concurrent.atomic.AtomicBoolean
Expand Down Expand Up @@ -41,9 +42,11 @@ internal class AnimationBackendChoreographer(
private val paused: AtomicBoolean = AtomicBoolean(true)

init {
// Register the self-reposting callback once, on the UI thread, so the
// callback queues are only ever mutated from the UI thread.
UiThreadUtil.runOnUiThread { postCallback() }
if (ReactNativeFeatureFlags.useSharedAnimatedBackend()) {
// Register the self-reposting callback once, on the UI thread, so the
// callback queues are only ever mutated from the UI thread.
UiThreadUtil.runOnUiThread { postCallback() }
}
}

fun resume() {
Expand Down
Loading