Update Yoga.podspec: fixes archiving for macos catalyst on react-native 0.73.1 in xcode

[kesha-antonov]

Hi

Summary:

When I tried to archive macos catalyst app in Xcode I got error:

This PR fixes archiving

Changelog:

[IOS] [FIXED] - fixed archiving for macos catalyst on react-native 0.73.1 in xcode

Test Plan:

Try archive react-native tester app for macos catalyst in Xcode

[facebook-github-bot]

@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@arushikesarwani94 merged this pull request in aa2d613.

[cipolleschi]

@kesha-antonov we will have to revert this PR because it isn't the right fix.
The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

[facebook-github-bot]

This pull request has been reverted by a4231a7.

[kesha-antonov]

@kesha-antonov we will have to revert this PR because it isn't the right fix. The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

What do we need to pass to PUBLIC_HEADERS_FOLDER_PATH?

I've tried and it doesn't work

module_name = 'yoga'

spec.pod_target_xcconfig = {
      'DEFINES_MODULE' => 'YES'
  }.merge!(ENV['USE_FRAMEWORKS'] != nil ? {
    'PUBLIC_HEADERS_FOLDER_PATH' => "#{module_name}.framework/Headers",
    'HEADER_SEARCH_PATHS' => create_header_search_path_for_frameworks('Yoga', framework_name: module_name)
}: {})

When I try to archive it still shows error when trying to import headers

The missing file that we see in the error is located here

react-native/ReactCommon/yoga/yoga/debug/Log.h

[kesha-antonov]

So I tried to use PUBLIC_HEADERS_FOLDER_PATH and it seems like it doesn't fix the issue.
What fixes is original solution - to add HEADER_SEARCH_PATHS

But better solution is to use "HEADER_SEARCH_PATHS" => "$(PODS_TARGET_SRCROOT)"

PODS_TARGET_SRCROOT is node_modules/react-native/ReactCommon/yoga

[kesha-antonov]

@kesha-antonov we will have to revert this PR because it isn't the right fix. The right way to handle Catalyst builds is to use the PUBLIC_HEADERS_FOLDER_PATH option, as we are doing here

Moreover, we have PUBLIC_HEADERS_FOLDER_PATH flag set by default in XCode

So I don't think it changes anything when we set it in podspec

Here's screenshot from xcode with default Yoga.podspec file without changes

[kesha-antonov]

I checked main branch. Apparently I made fix for 0.73.1 but commited in 0.74
My fix works with 0.73.1 but not with 0.74

[kesha-antonov]

Question is what to set in header_search_paths ?