Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule#39682
Closed
mdvacca wants to merge 3 commits into
Closed
Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule#39682mdvacca wants to merge 3 commits into
mdvacca wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
Base commit: e1d824f |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
566a19d to
6f209c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
6f209c1 to
2faf41a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
2faf41a to
af7cb2e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
af7cb2e to
75138b4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
75138b4 to
a34c756
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
a34c756 to
c77839e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
c77839e to
b60d990
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
b60d990 to
0b9f1d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
0b9f1d0 to
530631a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
mdvacca
force-pushed
the
export-D49523696
branch
from
530631a to
b147838
Compare
Summary: Move ReactHost to com.facebook.react chnagelog: [internal] internal Differential Revision: D49834870 fbshipit-source-id: e677fd19d00f4ba779fb277d69dd09f1d3952372
Summary: In this diff I'm removing TurboModuleManager from ReactHostDelegate. The goal is to stop exposing TurboModuleManager and TurboModuleRegistry Developers should use ReactContext.getNativeModule to retrieve native modules instead of TurboModuleManager or TurboModuleRegistry changelog: [internal] internal Differential Revision: D49483636 fbshipit-source-id: b3065f711a67272976751590d9bdc5339c99b439
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (react#39682) Summary: Pull Request resolved: react#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 495b5dab52026c7182ca81023eaa4c11401b2081
mdvacca
force-pushed
the
export-D49523696
branch
from
b147838 to
5fa9071
Compare
Generated by 🚫 dangerJS against b147838f4d33a459970ca8bcd5ee3a4a98c7b2bc |
|
This pull request was successfully merged by @mdvacca in b7191cd. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in b7191cd. |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 11, 2023
…odule.kt (react#41412) Summary: The PR react#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 11, 2023
…odule.kt (#41412) Summary: Pull Request resolved: #41412 The PR #39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule
Reviewed By: RSNara
Differential Revision: D49523696