[FIX] Add a check for scrollEnabled to VirtualizedList error #34637
Closed
annepham25 wants to merge 1 commit into
Closed
[FIX] Add a check for scrollEnabled to VirtualizedList error #34637annepham25 wants to merge 1 commit into
annepham25 wants to merge 1 commit into
Conversation
Base commit: 0e8050d |
Contributor
|
We can merge this in, but VirtualizedList_EXPERIMENTAL should soon be replacing VirtualizedList, if that also works. |
Base commit: 73abcba |
Author
|
@NickGerleman any update? |
Contributor
|
VietualizedList_EXPERIMENTAL will be merged into VirtualizedList in about a week, so it should likely be in the next release. |
Contributor
|
VirtualizedList_EXPERIMENTAL replaced the original for 0.71, so I think this should no longer be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Already merged PR here, but there was confusion that the changes should also be in
VirtualizedList_EXPERIMENTAL.jsandVirtualizedList.js, not one or the other.Changelog
[General] [Added] - Added a check to if
scrollEnabledis not false, if so then fire theVirtualizedListerror inVirtualizedList.jsto matchVirtualizedList_EXPERIMENTAL.js[CATEGORY] [TYPE] - Message
Test Plan
Passes all provided automatic tests. In a personal app, there is a situation of nested ScrollViews that had triggered the error. After defining scrollEnabled={false} and adding the check, the error no longer appears.
Previously spoke with @NickGerleman so @ mentioning him again to get attention.