local e2e tests - check if smoke-test to prevent jest watching

[tuchk4]

Now --watch flag for jest tests is disabled in two cases (scripts/test.js#L25):

• is CI
• or --coverage is added

but when run npm run e2e locally - tests always stops at first npm test - tasks/e2e-simple.sh#L117

Maybe add isSmokeTest check like at utils/createWebpackCompiler.js#L11?

// Watch unless on CI or in coverage mode
const isSmokeTest = process.argv.some(arg => arg.indexOf('--smoke-test') > -1)
if (!isSmokeTest && !process.env.CI && argv.indexOf('--coverage') < 0) {
  argv.push('--watch');
}

[gaearon]

Can we change local e2e to set CI to true?
Also, how did this ever work?

[tuchk4]

There are two places in code where process.env.CI is using:

• scripts/build.js#L87 - process.exit if process.env.CI compile warnings
• scripts/test.js#L25 - disable jest --watch flag

So it is possible to prevent jest watching using this CI=true npm run e2e.
Same way as here - #1460 (comment)

CI is set at *.sh tasks

[tuchk4]

Found it.

All npm test are run with CI=true except this one e2e-simple.sh#L266
(I thought that CI is automatically set by travis)

[tuchk4]

All is clear now. But I am confused a bit.
We have --smoke-test, CI env variable but for comfortable local test runs I should add at least two (CI=true and BROWSER=none) env variables.

[gaearon]

Send a PR as you see fit. I don’t use local testing much so it might be broken.