fix(ios): guard against nil localizedDescription in didFailToLocateUserWithError#5872
Open
isaacrowntree wants to merge 1 commit intoreact-native-maps:masterfrom
Conversation
…cateUserWithError Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
AIRMapManager.mwhereerror.localizedDescriptioncan benil, causing anNSInvalidArgumentExceptionwhen constructing the NSDictionary literal.Crash:
Stack trace:
Root cause
NSError.localizedDescriptionis documented to always return a non-nil string, but edge cases exist (custom error domains, specific iOS versions) where it can returnnil. The Objective-C dictionary literal@{ @"message": nil }crashes immediately.Fix
Add a nil-coalescing fallback:
error.localizedDescription ?: @"Unknown error"This is a one-line change with zero risk — it only affects the nil case which currently crashes.
Related
Test plan
localizedDescriptionis nil