Mapview leak memory on IOS

[kduy969]

Version: branch master, commit 21a7536
React native version: 0.59.1
Platform: IOS
Map Provider: Google.

Issue:
Each time I open a screen which contain a <MapView/> , memory go up about 50mb, but when I go back , memory not reduce the same amount ,try this a few times will make app crash. After that, I use Xcode profile tool to monitor leak event, this point out leak memory come from AIRGoogleMap[getActionForTarget] , despite I have no marker on MapView. When I remove <MapView/> from my screen, the issue gone away.

PS: I switch to master when trying to workaround a bug mentions here:
#2737 (comment)

[sebqq]

isn't this duplicate of #2775 ?

[sebqq]

Anyway, I'm also encountering some weird behaviour on iOS... On Android, everything works just perfect and smooth (even on emulator device). But on iOS with iPhone XR (The fastest Apple Bionic A12 chip) and release build, react-navigation transition is very laggy when I'm entering or leaving Map Screen.

I don't know if this is problem of react-navigation or react-native-map, but I'm using most current versions of react-native, react-native-maps and react-navigation.

[rborn]

@kduy969 thanks for this, please have a look at #2775 (what @sinodko said) and see if the same case and maybe add your findings to it.

(it has more details and info so we'll switch to that issue for this bug)

[sebqq]

@rborn can this memory leak be also related to the problem that I'm encountering?

[rborn]

@sinodko it might be this only if the lag starts after you enter/leave the map multiple times ( and assuming the leak is not related to the tiles which would do show on zoom or region chnage)
If it happens right away I don't really know what's going on.

Do you have this issue on any other device?

Maybe you're doing something fancy (like re-rendering multiple times or building stuff on an event that triggers often - like onRegionChange) ?

[sebqq]

I'm making SQLite call on componentDidMount which is fetching markers (there can be even 500+ markers) so there is some heavy liftings. I will take a look at number of renders in the component but the weird thing is that on mid-upper range android device is everything working smoothly but on top level iOS flagship (in terms of processor and power) the transition is crispy.

If I run SQLite query after transition is complete, then transition is more smooth. But then on "back" transition the performance is laggy again.

I will take a deeper look on that and if I'm not able to make it smooth I'll probably open new issue with additional info :)

[rborn]

500 markers? this is a lot

I'd suggest to implement some clustering and/or exclusion based on the zoom level and current region to reduce the number.

Can you try to use Instruments on the app maybe you find where the memory goes bonkers?

[sebqq]

I'm using the react-native-maps-super-cluster package for clustering and the performance on map is just fine even on old xperia Z2 during map moving/zooming. I'm even using onRegionChangeCompleted to recompute visible markers by viewport of the map widget - :) The problem only appears when I'm entering or leaving the map even when I open the Map which contains only 1 marker.

[rborn]

@sinodko apple map or google ? (maybe we can narrow the issue)

[sebqq]

@rborn Google Maps. I wanted to use AppleMaps but there was a problem with onRegionChangeCompleted firing while using custom tiles (only in offline mode) so I decided to go with Google Maps instead.

[ottoo]

Use 558b34c icon property on markers instead of the image property. This made a huge difference.

[kduy969]

@sinodko @rborn this may be same problem with #2775 , it's happen on Google Map too , the only difference is I don't have any marker on MapView. Every time I open screen with MapView , i see a leak memory event in Xcode profile tool, and the memory chart only going up after multiple open/close.

[sebqq]

@ottoo even when I'm using only default markers with their default look?